-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some OLM tests recently broken #4418
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess you mean these checks:
✅ TestOLMInstallation (5m49.82s)
✅ TestOLMInstallation/run_smoke_test_ephemeral (2m42.8s)
✅ TestOLMInstallation/run_smoke_test_pvc (14.72s)
Yeah, that is the problem of assuming some checks are failing. I'm working to solve the upgrade problem (as soon as we release 1.12.1 it will be fixed), so we can trust 100% our tests.
It seems this one has fixed those failing validation. Can I merge!? |
It depends if you are in a hurry to fix these 3 tests, because this revert will break this PR #4417 on S2I builder. Else I will work some more to have both the fixes and the S2I builder working in this PR. |
Ah, okey, I did not get that part. No hurry, feel free to go ahead with a solid solution then. |
This reverts commit 8272026.
… FS access for operator)
@squakez |
Thanks for taking care. I'll merge as soon as the checks are green then. |
Revert "feat(core): Fix Operator and Builder Pod user as non root 1000"
This reverts commit 8272026.
The user 0 (root) is set on:
Release Note