Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some OLM tests recently broken #4418

Merged
merged 2 commits into from
May 31, 2023
Merged

Conversation

gansheer
Copy link
Contributor

@gansheer gansheer commented May 29, 2023

Revert "feat(core): Fix Operator and Builder Pod user as non root 1000"

This reverts commit 8272026.

The user 0 (root) is set on:

  • Dockerfile's folders that the operatory copy
  • SecurityContext.FSGroup of the operator's pod

Release Note

Revert usage of non-root user (1000) on operator and builder pods FS.

Copy link
Contributor

@squakez squakez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you mean these checks:
✅ TestOLMInstallation (5m49.82s)
✅ TestOLMInstallation/run_smoke_test_ephemeral (2m42.8s)
✅ TestOLMInstallation/run_smoke_test_pvc (14.72s)

Yeah, that is the problem of assuming some checks are failing. I'm working to solve the upgrade problem (as soon as we release 1.12.1 it will be fixed), so we can trust 100% our tests.

@squakez
Copy link
Contributor

squakez commented May 29, 2023

It seems this one has fixed those failing validation. Can I merge!?

@gansheer
Copy link
Contributor Author

It depends if you are in a hurry to fix these 3 tests, because this revert will break this PR #4417 on S2I builder. Else I will work some more to have both the fixes and the S2I builder working in this PR.

@squakez
Copy link
Contributor

squakez commented May 29, 2023

It depends if you are in a hurry to fix these 3 tests, because this revert will break this PR #4417 on S2I builder. Else I will work some more to have both the fixes and the S2I builder working in this PR.

Ah, okey, I did not get that part. No hurry, feel free to go ahead with a solid solution then.

@gansheer
Copy link
Contributor Author

@squakez
My last commits where working, so I did some squashing on them. This version is good on the olm tests and the S2I builder. I will probably make some more modifications on permissions later when I can actually test the olm mode locally.

@gansheer gansheer changed the title [DO NOT MERGE] Fix some OLM tests recently broken Fix some OLM tests recently broken May 30, 2023
@squakez
Copy link
Contributor

squakez commented May 30, 2023

@squakez My last commits where working, so I did some squashing on them. This version is good on the olm tests and the S2I builder. I will probably make some more modifications on permissions later when I can actually test the olm mode locally.

Thanks for taking care. I'll merge as soon as the checks are green then.

@squakez squakez merged commit d7a6820 into apache:main May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants