chore: Improve Camel dependency validation #4411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Reuse logic in validate function just logging a warning and those validate function raising errors - Remove unused function ValidateDependencies - Add some unit tests - Add some documentation on Camel dependency resolution via catalog
christophd
force-pushed
the
chore/validate-camel-dependencies
branch
from
dcd397d to
7861866
Compare
oscerd
approved these changes
May 24, 2023
squakez
approved these changes
May 24, 2023
|
@squakez I think there has been an issue with the validate workflow recently? should I rebase? |
No worries, I am merging it anyway and it will rebased automatically. |
|
BTW, if we can backport to 1.12 branch then I will start the release process accordingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successor PR to #4402
Basically keeps the old logic of throwing errors when a dependency is not in the Camel catalog but adds some new unit tests and some improvements on the dependency validation functions