[Backport-1.12.x] fix: Restrict Knative service trait to Http exposed and passive endpoints #4379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ints - Only apply Knative service trait on integrations that either use passive consumers or expos at least one Http endpoint - Integrations are considered unsuitable for Knative service trait when they exclusively use active consumers that are not Http based - Do not use Knative service with `min-scale=1` for unsuitable integrations instead use normal deployment
oscerd
approved these changes
May 16, 2023
squakez
approved these changes
May 16, 2023
|
native check failure unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport of #4368
min-scale=1for unsuitable integrations instead use normal deployment