Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#4336): Restrict Knative binding provider execution #4344

Merged

Conversation

christophd
Copy link
Contributor

  • Only run the binding provider when Knative is installed on the cluster
  • Only run the binding provider when referencing a known Knative resource (e.g. broker, channel, service)

Fixes #4336

Release Note

fix: Restrict Knative binding provider execution

Copy link
Contributor

@squakez squakez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, thanks!

@squakez squakez added the kind/bug Something isn't working label May 9, 2023
- Only run the binding provider when Knative is installed on the cluster
- Only run the binding provider when referencing a known Knative resource (e.g. broker, channel, service)
@christophd christophd force-pushed the issue/4336/knative-ref-binding-provider branch from ac7672b to 00f8568 Compare May 9, 2023 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Binding from a Strimzi CR is not properly decoded
3 participants