Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Always uninstall IntegrationPlatform resources #4334

Conversation

christophd
Copy link
Contributor

  • Make sure to remove IntegrationPlatform resources from operator namespace on uninstall
  • Do not filter on label "app=camel-k" when removing IntegrationPlatform resources

Release Note

fix: Always uninstall IntegrationPlatform resources

- Make sure to remove IntegrationPlatform resources from operator namespace on uninstall
- Do not filter on label "app=camel-k" when removing IntegrationPlatform resources
Copy link
Contributor

@squakez squakez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the label app=camel-k is there on purpose, to control everything belonging to Camel K. Probably we should make sure that when we create any IntegrationPlatform from the operator, we do include the label instead. We may have a situation where the user deliberately create an IntegrationPlatform manually, but he does not want to remove on uninstall.

@christophd
Copy link
Contributor Author

@squakez there is a --skip-integration-platform option on the uninstall command for users that need to retain this resource

@squakez
Copy link
Contributor

squakez commented May 8, 2023

@squakez there is a --skip-integration-platform option on the uninstall command for users that need to retain this resource

I know, but that one would also skip any IP with app=camel-k. I don't have any strong opinion on this change anyhow, so, we can merge it if there is no other objection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants