Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add klb to olm_upgrade_test - branch 1.10.x #4323

Merged

Conversation

lfabriko
Copy link
Contributor

@lfabriko lfabriko commented May 4, 2023

No description provided.

@lfabriko
Copy link
Contributor Author

lfabriko commented May 4, 2023

  • Fails on cluster kind - viz upgrade workflow; observed also in original test
    olm_upgrade_test.go:115: Platform version: (empty)
  • Passes on openshift 4.12

@lfabriko lfabriko marked this pull request as draft May 4, 2023 21:27
@squakez
Copy link
Contributor

squakez commented May 5, 2023

The check may fail because #4312. We probably need to release a patched version and rebase this one in order to make sure it passes.

@lfabriko
Copy link
Contributor Author

lfabriko commented May 9, 2023

@squakez Iiuc the fix of #4312 (resp. #4301) seems already present in release-1.10.x from which is this branch forked: https://github.com/lfabriko/camel-k/blob/lfabriko-kbind-upgrade-rel1.10.x/pkg/cmd/operator/operator.go#L129-L131

Iiuc it was backported in edd3a2a

@squakez
Copy link
Contributor

squakez commented May 9, 2023

Yes, the problem is that the previous version we use to install (1.10.4 is the one that fails). In order to have it working, we'd need to release a new version for 1.10 branch, which I am not sure is something is going to happen. Let's reason on alternative way of testing this.

@lfabriko
Copy link
Contributor Author

lfabriko commented May 9, 2023

I see - thank you for info... I understand you proposed alternative way in #4312 (comment).

@squakez squakez marked this pull request as ready for review May 9, 2023 10:47
@squakez squakez marked this pull request as draft May 9, 2023 10:47
@lfabriko
Copy link
Contributor Author

lfabriko commented May 9, 2023

Just I observe the problem seems different - it fails 60 lines later, after installing the IntegrationPlatform https://github.com/apache/camel-k/actions/runs/4801843764/jobs/8544568267#step:4:2259...

@squakez squakez marked this pull request as ready for review May 9, 2023 12:35
@squakez
Copy link
Contributor

squakez commented May 9, 2023

Good point. Let's merge then as it seems the problem is the one related to the upgrade check.

@squakez squakez merged commit 65b286b into apache:release-1.10.x May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants