Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(trait): custom builder resources #4322

Merged
merged 7 commits into from
May 16, 2023
Merged

feat(trait): custom builder resources #4322

merged 7 commits into from
May 16, 2023

Conversation

squakez
Copy link
Contributor

@squakez squakez commented May 4, 2023 •
edited
Loading

With this PR we introduce the following resource configuration that can be applied for builder trait:

| builder.request-cpu
| string
| When using `pod` strategy, the minimum amount of CPU required by the pod builder.

| builder.request-memory
| string
| When using `pod` strategy, the minimum amount of memory required by the pod builder.

| builder.limit-cpu
| string
| When using `pod` strategy, the maximum amount of CPU required by the pod builder.

| builder.limit-memory
| string
| When using `pod` strategy, the maximum amount of memory required by the pod builder.

And we provide minimum default values for Quarkus native builds.

Closes #4177

Release Note

feat(trait): custom builder resources

@squakez squakez added the kind/feature New feature or request label May 4, 2023
@squakez squakez marked this pull request as draft May 4, 2023 10:10
@squakez squakez added the trigger native test Use this label in PR when you want to trigger Quarkus Native tests label May 4, 2023
@squakez squakez force-pushed the feat/4177_builder_config branch 5 times, most recently from 22482d8 to 13430f0 Compare May 9, 2023 15:32
@squakez squakez modified the milestone: 2.0.0 May 10, 2023
@squakez squakez force-pushed the feat/4177_builder_config branch from 73d5924 to ebb63bc Compare May 10, 2023 10:22
squakez added 4 commits May 10, 2023 16:37
@squakez
feat(api): create BuildConfiguration to host config
604390c 
This commit introduce the object we'll use to include later all builder config.

Ref apache#4177
@squakez
chore: default build strategy
b8a7d74
@squakez
chore(api): not required build strategy
61db6de
@squakez
feat(trait): builder pod resources config
ea2d927 
* Enabled resource configuration for builder pod
* Default resource configuration when Quarkus native build

Closes apache#4177
@squakez squakez force-pushed the feat/4177_builder_config branch from ebb63bc to 4279656 Compare May 10, 2023 14:42
@squakez squakez marked this pull request as ready for review May 10, 2023 14:46
@squakez squakez force-pushed the feat/4177_builder_config branch from 4279656 to 1a5efc6 Compare May 10, 2023 14:49
@squakez squakez changed the title feat: custom Build configuration feat(trait): custom builder resources May 10, 2023
@squakez squakez force-pushed the feat/4177_builder_config branch from 99a1549 to ba6fa7d Compare May 11, 2023 13:12
@squakez squakez merged commit 0cdd6a0 into apache:main May 16, 2023
@squakez squakez deleted the feat/4177_builder_config branch May 16, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kind/feature New feature or request trigger native test Use this label in PR when you want to trigger Quarkus Native tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Customize Builder resources when Quarkus Native
1 participant
@squakez