Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove deprecated code #4318

Merged
merged 5 commits into from
May 10, 2023
Merged

feat: remove deprecated code #4318

merged 5 commits into from
May 10, 2023

Conversation

squakez
Copy link
Contributor

@squakez squakez commented May 3, 2023

Close #4026

Release Note

feat: remove deprecated code

@gansheer
Copy link
Contributor

gansheer commented May 3, 2023

Should the tracing trait also be removed now ?

@squakez
Copy link
Contributor Author

squakez commented May 3, 2023

Should the tracing trait also be removed now ?

Not so easy. As it is part of the v1 API spec that we still support, we cannot remove it. API removal should be only be done in a major API upgrade. In Camel K V2, we're not upgrading Kubernetes API, so, we better leave it (although end users should not use the feature) for backward compatibility only.

@squakez squakez added the trigger native test Use this label in PR when you want to trigger Quarkus Native tests label May 4, 2023
@squakez squakez force-pushed the feat/4026 branch 11 times, most recently from 463d160 to f699adb Compare May 10, 2023 07:21
@squakez
Copy link
Contributor Author

squakez commented May 10, 2023

Check failure due to regression to be fixed by #4358. Merging.

@squakez squakez merged commit 67f8671 into apache:main May 10, 2023
@squakez squakez deleted the feat/4026 branch May 10, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
trigger native test Use this label in PR when you want to trigger Quarkus Native tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove all deprecated code in 1.x version
2 participants
@squakez @gansheer