fix: Consistent integration platform settings hierarchy #4317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squakez
changed the title
|
Please, mind the conflict. Some other PR changing the same file was merged in the while. |
- Make sure to apply global integration platform settings when creating namespace local platform - Always derive local platform from operator global platform settings - Global platform settings resist when the setting is not explicitly overwritten in the given user namespaced integration platform
christophd
force-pushed
the
issue/CMLK-203/integration-platform-hierarchy
branch
from
3d8b07c to
da08274
Compare
|
@squakez thx, rebase is done. Now we need to run the full workflow jobs once again 😅 |
gansheer
approved these changes
May 4, 2023
christophd
added a commit
to christophd/camel-k
that referenced
this pull request
May 8, 2023
…che#4317) - Make sure to apply global integration platform settings when creating namespace local platform - Always derive local platform from operator global platform settings - Global platform settings resist when the setting is not explicitly overwritten in the given user namespaced integration platform
christophd
added a commit
to christophd/camel-k
that referenced
this pull request
May 8, 2023
…che#4317) - Make sure to apply global integration platform settings when creating namespace local platform - Always derive local platform from operator global platform settings - Global platform settings resist when the setting is not explicitly overwritten in the given user namespaced integration platform
christophd
added a commit
to christophd/camel-k
that referenced
this pull request
May 8, 2023
…che#4317) - Make sure to apply global integration platform settings when creating namespace local platform - Always derive local platform from operator global platform settings - Global platform settings resist when the setting is not explicitly overwritten in the given user namespaced integration platform
squakez
pushed a commit
that referenced
this pull request
May 9, 2023
- Make sure to apply global integration platform settings when creating namespace local platform - Always derive local platform from operator global platform settings - Global platform settings resist when the setting is not explicitly overwritten in the given user namespaced integration platform
christophd
added a commit
to christophd/camel-k
that referenced
this pull request
May 9, 2023
…che#4317) - Make sure to apply global integration platform settings when creating namespace local platform - Always derive local platform from operator global platform settings - Global platform settings resist when the setting is not explicitly overwritten in the given user namespaced integration platform
squakez
pushed a commit
that referenced
this pull request
May 11, 2023
- Make sure to apply global integration platform settings when creating namespace local platform - Always derive local platform from operator global platform settings - Global platform settings resist when the setting is not explicitly overwritten in the given user namespaced integration platform
squakez
pushed a commit
to jboss-fuse/camel-k
that referenced
this pull request
May 11, 2023
…che#4317) - Make sure to apply global integration platform settings when creating namespace local platform - Always derive local platform from operator global platform settings - Global platform settings resist when the setting is not explicitly overwritten in the given user namespaced integration platform (cherry picked from commit apache/camel-k@b479dbe9e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users are allowed to create namespace local IntegrationPlatform resources in order to overwrite settings used in the operator.
These namespace local platform settings should derive from the IntegrationPlatform being used by the operator by default. This means that only explicitly specified settings do overwrite the platform defaults used in the operator.
This PR makes sure that we use a consistent platform settings hierarchy where the global operator platform settings always represent the basis for user specified platform settings.
The changes in this PR:
Release Note