Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(operator): do not panic if cannot set GOMAXPROCS #4300

Merged
merged 3 commits into from
Apr 28, 2023

Conversation

squakez
Copy link
Contributor

@squakez squakez commented Apr 28, 2023

Closes #4299

Release Note

fix(operator): do not panic if cannot set GOMAXPROCS

@squakez squakez added the kind/bug Something isn't working label Apr 28, 2023
@squakez
Copy link
Contributor Author

squakez commented Apr 28, 2023

@astefanutti I'd like your opinion on this one. I have the feeling we should be safe by just logging the error (then it will be up to the operator installer to figure it out how to solve this problem to improve concurrency). In this way we at least let the operator run in situations where we cannot control the cluster (ie, the github actions which suddenly stopped to work).

@squakez squakez merged commit 7eb0d25 into apache:main Apr 28, 2023
@squakez squakez deleted the fix/ci_failure branch April 28, 2023 14:00
@squakez
Copy link
Contributor Author

squakez commented Apr 28, 2023

Merging, so that we can keep the development and other PRs ahead. We can keep discussing in #4299

@astefanutti
Copy link
Member

@astefanutti I'd like your opinion on this one. I have the feeling we should be safe by just logging the error (then it will be up to the operator installer to figure it out how to solve this problem to improve concurrency). In this way we at least let the operator run in situations where we cannot control the cluster (ie, the github actions which suddenly stopped to work).

@squakez sorry for the late reply, this felt under my radar. Error logging looks like a pragmatic approach. I think situations where this could lead to nasty issues are very seldom. This would ideally go away anyway with golang/go#33803.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot set GOMAXPROCS
3 participants