Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(trait): Migrate prometheus trait from microprofile metrics to micrometer #4211

Merged

Conversation

gansheer
Copy link
Contributor

Fixes #1773

Motivation

In Quarkus 3 / Camel 4, microprofile-metrics will be removed, and micrometer extension is its replacement.
The prometheus trait need to be modified to use the micrometer extension.

Description

The micrometer extension replaces the microprofile extension, with the additional prometheus registry.
The e2e existing test is updated to be the most similar as possible in terms of metrics tested, but since micrometer offers less possibilities there are some adaptations.

Release Note

Migrate prometheus trait from microprofile metrics to micrometer

@gansheer
Copy link
Contributor Author

The PR is in draft until I manage to fix the e2e test.

@gansheer gansheer force-pushed the feature/1773_micrometer_metrics_for_prometheus branch from 73e9abd to cbfc190 Compare March 31, 2023 14:45
@gansheer gansheer force-pushed the feature/1773_micrometer_metrics_for_prometheus branch from cbfc190 to f4fa4ee Compare April 3, 2023 11:08
@gansheer
Copy link
Contributor Author

gansheer commented Apr 3, 2023

I am trying to see if it is possible to add in the prometheus trait code the addition of a builder property quarkus.micrometer.export.json.enabled=true to ensure json api is available by default. I haven't manage to. Is there a way to do it while acting on the e *Environment object ?

@squakez
Copy link
Contributor

squakez commented Apr 3, 2023

I think this is another case where we need to understand how to implement a trait leaving implementation details about runtime outside of Camel K: #4166

@gansheer
Copy link
Contributor Author

gansheer commented Apr 3, 2023

I think this is another case where we need to understand how to implement a trait leaving implementation details about runtime outside of Camel K: #4166

I see, I will exclude it from the idea from this issue and add how to activate JSON's API it in the documentation's example for now.

@gansheer gansheer marked this pull request as ready for review April 3, 2023 14:40
@squakez squakez merged commit d5b9466 into apache:main Apr 4, 2023
@squakez
Copy link
Contributor

squakez commented Apr 4, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default to using Micrometer for integration monitoring
3 participants