fix(cli): Remove CamelCatalogs CR on kamel uninstall #4162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Mar 24, 2023
squakez
approved these changes
Mar 24, 2023
| @@ -62,6 +63,7 @@ func newCmdUninstall(rootCmdOptions *RootCmdOptions) (*cobra.Command, *uninstall | |||
| cmd.Flags().Bool("skip-config-maps", false, "Do not uninstall the Camel K Config Maps in the current namespace") | |||
| cmd.Flags().Bool("skip-registry-secret", false, "Do not uninstall the Camel K Registry Secret in the current namespace") | |||
| cmd.Flags().Bool("skip-kamelets", false, "Do not uninstall the Kamelets in the current namespace") | |||
| cmd.Flags().Bool("skip-camel-catalogs", false, "Do not uninstall the Camel Catalogs in the current namespace") | |||
There was a problem hiding this comment.
+1 for this. Really good idea, thanks!
gansheer
commented
Mar 24, 2023
pkg/util/defaults/defaults.go
Outdated
| @@ -26,7 +26,7 @@ const ( | |||
| Version = "2.0.0-SNAPSHOT" | |||
|
|
|||
| // DefaultRuntimeVersion -- | |||
| DefaultRuntimeVersion = "1.18.0-SNAPSHOT" | |||
| DefaultRuntimeVersion = "3.20.1-SNAPSHOT" | |||
There was a problem hiding this comment.
This was changed automatically, should I revert this change ?
gansheer
force-pushed
the
fix/4160_cli_uninstall_all_camelcatalog
branch
from
8b9b579 to
0005546
Compare
gansheer
force-pushed
the
fix/4160_cli_uninstall_all_camelcatalog
branch
from
0005546 to
a08fc76
Compare
|
Please, let me know when this is ready to be merged. |
|
Check failure unrelated. Merging. |
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4160
Motivation
When using
kamel uninstallcommand the CamelCatalogs CR are not removed from the cluster. When an operator with the same Runtime is installed, it is already considered as Ready so the builder image container is not builded again with the code from the operator.Description
Remove all the CamelCatalogs in the namespace of the operator on
kamel uninstall calland add askip-camel-catalogsflag.Release Note