[Backport 1.12.x] fix(builder): native from source should rebuild #4161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Mar 24, 2023
|
I am not able to understand why this is failing in CI. Locally I can run that test successfully. I have the feeling it could be because of limited resources. What it puzzles me is that it always fail in the same place. @essobedo maybe you have some better idea why this is failing on GH? |
|
@squakez it looks like you found the problem, the name of the file must match with the name of the class |
Yes, but after that one I had to retry native tests four times. It seems this last retry got scared as I was seeking help 😝 - gonna merge before it turns red again... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Note