Chore: docker, jvm unit tests #4154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Mar 23, 2023
squakez
reviewed
Mar 23, 2023
There was a problem hiding this comment.
Nice work, thanks! I think that test is failing because the issue that is going to be fixed with #4155 - As that method is refactored, once that PR is merged I suggest you rebase this PR and remove the test that is no longer needed.
added 3 commits
March 24, 2023 09:43
* docker test * comprss test * keystore test * camel util test
* docker test
*Updated TestRunImageArgs to adapt to changes made in RunImageArgs
realMartinez
force-pushed
the
feat/unit_test
branch
from
b50c21c to
4465534
Compare
squakez
approved these changes
Mar 24, 2023
|
Checks failures not related. Merging. |
|
Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added unit tests for docker package. (Coverage 0->87.6%)
Added unit tests for jvm package. (Coverage 0->69.6%)
Added unit tests for camel package. (26.3%->28.8%)
Added unit tests for gzip package. (Specifically Compress64 and Uncompress64)
*Note: Due to unresolved issue, unit tests TestRunImageArgs in docker package fails
Release Note