feat: move code to version 2 #4128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Mar 13, 2023
squakez
force-pushed
the
fix/v2
branch
2 times, most recently
from
3c5fd72 to
7b111e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Altough it's a big PR, this one simply replaces all v1 version code to v2, according Golang way to upgrade. Any Camel K client will have to upgrade accordingly if wants to use the version 2.
About API it can be a bit misleading as a user sees for instance
v1 "github.com/apache/camel-k/v2/pkg/apis/camel/v1"where the first v2 represent the repository version, whilst the second v1 represent the Kubernetes version. In any case, this is something we cannot help unless we move the API outside the repository.Closes #4086
Release Note