Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(olm): bump framework operator sdk from v1.16.0 to v1.26.1 #4106

Merged
merged 1 commit into from
Mar 8, 2023

Conversation

gansheer
Copy link
Contributor

@gansheer gansheer commented Mar 6, 2023

Fixes #4105

Release Note

Bump framework operator sdk from v1.16.0 to v1.26.1

Copy link
Contributor

@oscerd oscerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this will affect also the prepare-operators script, I suppose

Copy link
Contributor

@oscerd oscerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good btw

@gansheer
Copy link
Contributor Author

gansheer commented Mar 6, 2023

I made some test on the bundle generated (in local build) between 1.16 and 1.26.1 and I get this result:

diff -r bundle/ bundle_1.26/
diff -r bundle/Dockerfile bundle_1.26/Dockerfile
10c10
< LABEL operators.operatorframework.io.metrics.builder=operator-sdk-v1.15.0+git
---
> LABEL operators.operatorframework.io.metrics.builder=operator-sdk-v1.26.1
diff -r bundle/manifests/camel-k.clusterserviceversion.yaml bundle_1.26/manifests/camel-k.clusterserviceversion.yaml
197c197
<     createdAt: "2023-03-06T16:21:10Z"
---
>     createdAt: "2023-03-06T16:19:27Z"
200c200
<     operators.operatorframework.io/builder: operator-sdk-v1.15.0+git
---
>     operators.operatorframework.io/builder: operator-sdk-v1.26.1
329c329,336
<       - name: camel-k-operator
---
>       - label:
>           app: camel-k
>           app.kubernetes.io/component: operator
>           app.kubernetes.io/name: camel-k
>           app.kubernetes.io/version: 2.0.0-SNAPSHOT
>           camel.apache.org/component: operator
>           name: camel-k-operator
>         name: camel-k-operator
diff -r bundle/metadata/annotations.yaml bundle_1.26/metadata/annotations.yaml
9c9
<   operators.operatorframework.io.metrics.builder: operator-sdk-v1.15.0+git
---
>   operators.operatorframework.io.metrics.builder: operator-sdk-v1.26.1

Is there something that should cause some concern in this result from your experience @oscerd ?

@oscerd
Copy link
Contributor

oscerd commented Mar 6, 2023

I made some test on the bundle generated (in local build) between 1.16 and 1.26.1 and I get this result:

diff -r bundle/ bundle_1.26/
diff -r bundle/Dockerfile bundle_1.26/Dockerfile
10c10
< LABEL operators.operatorframework.io.metrics.builder=operator-sdk-v1.15.0+git
---
> LABEL operators.operatorframework.io.metrics.builder=operator-sdk-v1.26.1
diff -r bundle/manifests/camel-k.clusterserviceversion.yaml bundle_1.26/manifests/camel-k.clusterserviceversion.yaml
197c197
<     createdAt: "2023-03-06T16:21:10Z"
---
>     createdAt: "2023-03-06T16:19:27Z"
200c200
<     operators.operatorframework.io/builder: operator-sdk-v1.15.0+git
---
>     operators.operatorframework.io/builder: operator-sdk-v1.26.1
329c329,336
<       - name: camel-k-operator
---
>       - label:
>           app: camel-k
>           app.kubernetes.io/component: operator
>           app.kubernetes.io/name: camel-k
>           app.kubernetes.io/version: 2.0.0-SNAPSHOT
>           camel.apache.org/component: operator
>           name: camel-k-operator
>         name: camel-k-operator
diff -r bundle/metadata/annotations.yaml bundle_1.26/metadata/annotations.yaml
9c9
<   operators.operatorframework.io.metrics.builder: operator-sdk-v1.15.0+git
---
>   operators.operatorframework.io.metrics.builder: operator-sdk-v1.26.1

Is there something that should cause some concern in this result from your experience @oscerd ?

Nothing looks weird, we'll need to check once we create PR in operator hub and community prod for Openshift. The truth will be when they will test through their pipelines.

@squakez
Copy link
Contributor

squakez commented Mar 7, 2023

@gansheer the diff looks okey, no major changes in the bundle, so I don't think there won't be any problem. Let's wait the checks I've re-executed just to make sure there is no problem, in particular in the OLM suite.

@squakez
Copy link
Contributor

squakez commented Mar 7, 2023

@gansheer all looks good. Waiting your ok to merge this.

@gansheer
Copy link
Contributor Author

gansheer commented Mar 8, 2023

@squakez LGTM too. Since no other concern has been raised I guess it's ready for merge 👍 .

@squakez squakez merged commit 5467424 into apache:main Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Operator Framework SDK version
3 participants