fix(#3956): Add maven settings-security.xml to maven command #4099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Mar 3, 2023
squakez
approved these changes
Mar 3, 2023
I don't think I can make an e2e test, I would need a private repository for it. Except if one already exists in the existing tests I don't see a simple way to do it. I made my local tests deploying a nexus server and it was not that simple. As for a Unit test I am trying to write one on the Do() method but it's kind of a mess. |
|
@gansheer no worry then, I'm merging, thanks! |
|
Btw, please backport to both 1.10 and 1.12 if possible. |
This was referenced Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #3956
Description
In case the settings-security.xml file is declared in the integration platform as described in the documentation it needs to be explicitly specified as part of the maven commands, else maven default to
${user.home}/.m2/settings-security.xmlinstead of/tmp/kit-xxxx/maven/settings-security.xml.Release Note