Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add path-based Ingress options to the ingress trait #4088

Merged
merged 8 commits into from
Mar 2, 2023
Merged

feat: Add path-based Ingress options to the ingress trait #4088

merged 8 commits into from
Mar 2, 2023

Conversation

astefanutti
Copy link
Member

This PR adds a set of new options to the ingress trait, so it's possible to configure "path-based" Ingress.

As ingresses can traditionally be configured based on annotations, e.g. with the NGINX ingress controller, this PR coincidentally adds support to set trait options of type map from the CLI, e.g.:

$ kamel run \
-t ingress.annotations.'nginx.ingress.kubernetes.io/use-regex'=true \
-t ingress.annotations.'nginx.ingress.kubernetes.io/rewrite-target'='/$2' \
-t ingress.path='/base_path(/|$)(.*)'

Release Note

feat(trait): Add path-based Ingress options to ingress trait
feat(cli): Support setting maps in traits API

@astefanutti astefanutti added the kind/feature New feature or request label Mar 1, 2023
@oscerd
Copy link
Contributor

oscerd commented Mar 1, 2023

Just a reminder, this will go in 2.x, if this is something we want for 1.x, we need to backport on 1.12.x

@astefanutti
Copy link
Member Author

@oscerd thanks for the reminder. I've created #4090 that targets the release-1.12.x branch, which I assumed is the current 1.x branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants