Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-architecture support #1238 #3820

Closed
wants to merge 16 commits into from
Closed

Multi-architecture support #1238 #3820

wants to merge 16 commits into from

Conversation

tobiasoort
Copy link

#1238

  • pushes container basis to quarkus v22.0.0.2
  • implements multi-arch (arm64 and amd64 only since thats whats provided upstream @ quarkus)
  • no cleanup of old 'arch' build yet, since I don't know what's dependent upon it.

This PR may be imperfect as I don't yet know how to run a test suite here and am hoping PRs have automated QC actions.

Release Note

- pushed quarkus version to v22.0.0.2 
- implemented multi-arch for amd64/arm64

@tobiasoort tobiasoort mentioned this pull request Nov 16, 2022
5 tasks
Copy link
Member

@tadayosi tadayosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many checks are failing. Please fix:

docker buildx create --append --name builder
WARNING: failed to find "builder" for append, creating a new instance instead
builder
docker buildx build --platform=linux/amd64,linux/arm64 -t kind-registry:5000/apache/camel-k:1.11.0-SNAPSHOT -f build/Dockerfile .
ERROR: multiple platforms feature is currently not supported for docker driver. Please switch to a different driver (eg. "docker buildx create --use")

script/Makefile Outdated Show resolved Hide resolved
@tobiasoort
Copy link
Author

So I just 'manually' added qemu support. This isn't the best way! The cleanest way is through github actions, as described here: https://github.com/marketplace/actions/docker-setup-buildx

It seems though that the build architecture/setup for this project is a bit 'manual' and I don't want to pull all that refactoring into this (intented to be) simple, small fixup PR.

@tobiasoort
Copy link
Author

tobiasoort commented Nov 17, 2022

I'm currently not able to test this in my local branch due to a dependency on kind-registry which cannot be resolved. I'm pretty sure thats environment-specific so please start the pipelines here again so we can see how it works here. Thanks!

edit: this was nonsense. I am working on a fix :)

@tadayosi
Copy link
Member

@tobiasoort Can you squash the commits into single one? It's too many for the simple fix.

@phantomjinx What do you think about the fix?

@squakez
Copy link
Contributor

squakez commented Nov 18, 2022

We can "squash and merge" instead of "rebase and merge". I think however the parameter setting for the platform is a must before going.

@tobiasoort
Copy link
Author

Do we want the built arch(s) in the VERSIONFILE?

@tobiasoort tobiasoort marked this pull request as draft November 24, 2022 19:01
@tobiasoort
Copy link
Author

I'll work on this PR in my fork and create a new one because this mess is only causing useless notifications for you.

@tobiasoort tobiasoort closed this Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants