-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-architecture support #1238 #3820
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many checks are failing. Please fix:
docker buildx create --append --name builder
WARNING: failed to find "builder" for append, creating a new instance instead
builder
docker buildx build --platform=linux/amd64,linux/arm64 -t kind-registry:5000/apache/camel-k:1.11.0-SNAPSHOT -f build/Dockerfile .
ERROR: multiple platforms feature is currently not supported for docker driver. Please switch to a different driver (eg. "docker buildx create --use")
So I just 'manually' added qemu support. This isn't the best way! The cleanest way is through github actions, as described here: https://github.com/marketplace/actions/docker-setup-buildx It seems though that the build architecture/setup for this project is a bit 'manual' and I don't want to pull all that refactoring into this (intented to be) simple, small fixup PR. |
edit: this was nonsense. I am working on a fix :) |
@tobiasoort Can you squash the commits into single one? It's too many for the simple fix. @phantomjinx What do you think about the fix? |
We can "squash and merge" instead of "rebase and merge". I think however the parameter setting for the platform is a must before going. |
Do we want the built arch(s) in the |
I'll work on this PR in my fork and create a new one because this mess is only causing useless notifications for you. |
#1238
This PR may be imperfect as I don't yet know how to run a test suite here and am hoping PRs have automated QC actions.
Release Note