feat(cli/run): Support dependencies defined using HTTP URLs #3644
Conversation
essobedo
force-pushed
the
240/http-dependencies
branch
from
d73d1fa to
db5202d
Compare
There was a problem hiding this comment.
Looks good, but it'd be great if there is e2e for the feature. Maybe here or here?
https://github.com/apache/camel-k/blob/main/e2e/namespace/install/cli/run_test.go
https://github.com/apache/camel-k/blob/main/e2e/global/registry/registry_maven_wagon_test.go
We can use the same jar used in the JVM trait: - we may just reference the http location of that one. |
essobedo
force-pushed
the
240/http-dependencies
branch
from
db5202d to
03b758b
Compare
| @@ -129,5 +129,14 @@ func TestKamelCLIRun(t *testing.T) { | |||
| // Clean up | |||
| Expect(Kamel("delete", "--all", "-n", ns).Execute()).To(Succeed()) | |||
| }) | |||
| t.Run("Run with http dependency", func(t *testing.T) { | |||
There was a problem hiding this comment.
Elegant way to reuse the test we already have but with a different scope. Kudos!
essobedo
force-pushed
the
240/http-dependencies
branch
from
03b758b to
4bd853f
Compare
essobedo
force-pushed
the
240/http-dependencies
branch
from
4bd853f to
6b448c0
Compare
fixes #240
Motivation
We allow
mvn:dependencies withcamel:andruntime:wrapper. We should allow users to specify HTTP dependencies on libs (to load custom JAR that are not present in Maven central).Modifications:
httpandhttpsprefixes to a temporary folderRelease Note