Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(trait): Provide the service type from the trait configuration #3618

Merged
merged 1 commit into from
Sep 9, 2022
Merged

feat(trait): Provide the service type from the trait configuration #3618

merged 1 commit into from
Sep 9, 2022

Conversation

essobedo
Copy link
Contributor

@essobedo essobedo commented Sep 7, 2022

fixes #1070

Motivation

So far only NodePort and ClusterIP are possible as service types, we would like to support LoadBalancer too

Modification

  • Add an enumeration representing the support service type in the service trait configuration
  • Add a deprecation note to the flag NodePort

Release Note

Allow providing the service type from the service trait configuration

@essobedo essobedo mentioned this pull request Sep 7, 2022
Closed
@essobedo essobedo force-pushed the 1070/provide-service-type branch from 882564f to def6533 Compare September 8, 2022 07:18
squakez
squakez approved these changes Sep 8, 2022
View reviewed changes
Copy link
Contributor

@squakez squakez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice stuff, +1 for e2e testing!

@essobedo essobedo force-pushed the 1070/provide-service-type branch from def6533 to 36c9479 Compare September 8, 2022 10:09
@tadayosi tadayosi merged commit 4d24894 into main Sep 9, 2022
@claudio4j claudio4j deleted the 1070/provide-service-type branch May 18, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squakez squakez squakez approved these changes

@oscerd oscerd oscerd approved these changes

@tadayosi tadayosi tadayosi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Camel K doesn't support kubernetes services of type loadbalancer
4 participants
@essobedo @tadayosi @oscerd @squakez