-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): Add a config command to manage the default settings #3599
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's an awesome enhancement! To understand how this cmd intends to be used, could you provide some example usages? It'd be also great if you could add a section for the usages of the cmd here:
https://github.com/apache/camel-k/blob/main/docs/modules/ROOT/pages/cli/file-based-config.adoc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. However, some example on how to use the new command would be good to see how it works. Either as a documentation or as an additional comment to this PR.
214ae9a
to
6a6a3a3
Compare
I've just added some doc hoping that it clarifies it a little bit more |
ae2500e
to
172e8f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'd make an additional effort to include an E2E test to make sure we won't break this feature in the future.
Do you mean that E2E tests are also expected even for pure client-side features? I mean the operator is not involved and it only manipulates local files on the client side that is why I proposed only unit tests. I have a test that checks the behavior too https://github.com/apache/camel-k/pull/3599/files#diff-4e0df340b8c06d6aa9b35d150ac8f92bd3581782cbe423209151170311ccbc6dR120-R137, do you still prefer to have an additional E2E test? |
@essobedo yeah, I think we can test this as well. I think we can have this configuration file with default namespace created ad hoc from the test (instead of using the |
For E2E, this place should be ideal to put some |
172e8f1
to
e05498e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, looks good!
e05498e
to
123190c
Compare
123190c
to
dd50d80
Compare
fixes #1184
Motivation
If we don't want to execute the commands against the default namespace, we need to add the flag
-n
to all commands or use the commandkubectl config set-context --current --namespace=<my-namespace>
to set the default namespace at kubectl config level, but we would like to propose something out of the box in kamel cliModifications:
config
to set the default namespace and list the existing settingsfile-based-config.adoc
Release Note