feat(build): Golang 1.17 #3432
Merged
feat(build): Golang 1.17 #3432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Jul 11, 2022
squakez
force-pushed
the
feat/go_117
branch
3 times, most recently
from
3f20232 to
ebb067a
Compare
tadayosi
requested changes
Jul 12, 2022
|
I've made some important change to how we interact with codegen tools. Now we install them in order to make sure we use the proper version. Thanks for your suggestions @tadayosi, feel free to have a further look now. |
tadayosi
reviewed
Jul 13, 2022
... which were missing it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR we requires Golang 1.17 minimum version for build. Codegen tools are always installed in order to make sure to use the expected version (instead of using the cached one that may become obsolete).
Supersede #3426
Release Note