-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): environment promotion #3325
Conversation
Looks great! Here is my early feedback on the feature:
|
Thanks for the feedback, much appreciated!!
I think it still can be done. The idea is that we copy the Integration spec plus the container which was tested and validated in a previous stage. I think the destination operator should be still able to cope with that.
We may understand which is the best ux there. If I am not wrong, the client we use to interact with the cluster is inheriting privileges from the user who has performed the login. I guess in a very first iteration we can let it fail, and add a check for valid permission in a later stage if we want.
Yeah, that is something we should analyze better. I've already thought we should check for various resources in the destination namespace. We should include also some parameter in order to transform the "typical" resources bound to an environment (annotations, envs, affininity/tolerations, etc...). |
* Check compatibility version between source and dest operators * Copy the Integration spec from namespace source to ns dest * Set container.image trait on destination to reuse image from the source Integration
e786882
to
4877cea
Compare
f799aff
to
533f662
Compare
With this PR the user can run:
in order to copy the Integration spec and the related container image from one environment (namespace) to another. In order to work the Operators have to share the same Image registry.
Features:
container.image
trait on destination to reuse image (tested) from the source IntegrationRelease Note