Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): let bom managed by camel k runtime #3317

Merged
merged 1 commit into from
Aug 24, 2022

Conversation

squakez
Copy link
Contributor

@squakez squakez commented May 30, 2022

With this PR, we remove the dependency from the platform. We'll let the runtime to manage them accordingly. It will also require some change on Camel K Runtime apache/camel-k-runtime#827

Release Note

chore(build): let bom managed by camel k runtime

@squakez
Copy link
Contributor Author

squakez commented May 30, 2022

@squakez
Copy link
Contributor Author

squakez commented May 31, 2022

I think this is failing because we need the changes in apache/camel-k-runtime#827 to be available. @oscerd which would be the best strategy to use a new change in the camel k runtime? putting this on hold until the camel k runtime is released? Thanks.

@oscerd
Copy link
Contributor

oscerd commented Jun 13, 2022

I think this is failing because we need the changes in apache/camel-k-runtime#827 to be available. @oscerd which would be the best strategy to use a new change in the camel k runtime? putting this on hold until the camel k runtime is released? Thanks.

Yes, for the moment.

@squakez squakez added the status/wip Work in progress label Jun 13, 2022
@squakez squakez marked this pull request as draft June 13, 2022 07:13
@squakez
Copy link
Contributor Author

squakez commented Jun 13, 2022

Moving as a draft to avoid any unintentional merge. It will need to be merged during next 1.10 release cycle, as soon as camel k runtime version is officially released as well.

@squakez squakez added this to the 1.10.0 milestone Jun 20, 2022
@tadayosi tadayosi mentioned this pull request Aug 22, 2022
@oscerd
Copy link
Contributor

oscerd commented Aug 23, 2022

@squakez can we rebase this and make it ready for review?

@squakez squakez force-pushed the chore/quarkus_deps branch from 6ec9acf to 988924e Compare August 23, 2022 07:14
@squakez squakez marked this pull request as ready for review August 23, 2022 07:14
@squakez squakez removed the status/wip Work in progress label Aug 23, 2022
@squakez
Copy link
Contributor Author

squakez commented Aug 24, 2022

Root cause failures are:

org.graalvm.polyglot.PolyglotException: java.lang.IllegalStateException: Duplicate language id regex. First language [Language class com.oracle.truffle.regex.RegexLanguage, Loaded from file:/deployments/dependencies/lib/main/org.graalvm.regex.regex-22.1.0.jar]. Second language [Language class com.oracle.truffle.regex.RegexLanguage, Loaded from file:/deployments/dependencies/lib/main/org.graalvm.regex.regex-22.1.0.jar].

However it seems they are the same of the ones happening in the main branch. I suggest to merge and solve in the main branch.

@oscerd
Copy link
Contributor

oscerd commented Aug 24, 2022

ok, let's merge.

@oscerd oscerd merged commit 91dcd82 into apache:main Aug 24, 2022
@squakez squakez deleted the chore/quarkus_deps branch August 24, 2022 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants