-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Mount trait example #3166
Add Mount trait example #3166
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have that scenario covered as suggested in the related issue https://github.com/apache/camel-k/tree/main/examples/volumes. I think we need to go beyond the simple timer to log example. One suggestion I can do is to provide some realistic situation. In the volume example, you can see I've created a producer Integration writing and a consumer Integration reading to/from a shared Volume.
You may think on some alternative situation, for example, showing how to log the camel k to an external volume (see https://stackoverflow.com/a/70063203/10974363 for details how to specify log file path). Then you can show how you can scrape that log from another integration.
It's just an idea. I guess the final goal of these activities is to get a bit of knowledge on the platform.
7e81d12
to
89ca59c
Compare
@squakez I took your idea. Can you review please? |
ba77e4c
to
825212a
Compare
I think we still need something. Let me provide here a sort of script the user could run, and you will be able to provide the related Integrations:
The Producer could be a timer to log Integration. You can provide some incremental counter, ie, simple language |
78d5595
to
c73c9e1
Compare
@squakez I did this. Please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work, thanks! Just remove the references of the Pod creation which are superfluous.
examples/traits/mount/README.md
Outdated
Requirement: Persistent Volume already created. | ||
|
||
Create the Pod and the Persistent Volume Claim: | ||
`kubectl apply -f pod-example.yaml` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need any live Pod for the PVC to be usable. You can just remove this line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done!
@@ -0,0 +1,11 @@ | |||
apiVersion: v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This yaml is not needed, you can remove it.
@squakez can this be merged now? |
fixes #3140
Release Note