chore(jolokia): upgrade to Jolokia 1.7.0 #2594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Aug 25, 2021
astefanutti
approved these changes
Aug 25, 2021
|
There is an error during the build: |
|
@astefanutti It's because jolokia-jvm 1.7.0 pom is somewhat broken (hardcoded macOS' system tools.jar dependency in the published pom). I did a bit dirty fix that explicitly exclude Please review again and let me know if there is a cleaner way. At this moment, I also think there should be a way to specify exclusions for a dependency via Dependencies trait. |
astefanutti
approved these changes
Aug 26, 2021
pkg/util/camel/camel_dependencies.go
Outdated
| @@ -89,6 +89,14 @@ func ManageIntegrationDependencies( | |||
| gav := strings.TrimPrefix(d, "mvn:") | |||
|
|
|||
| project.AddEncodedDependencyGAV(gav) | |||
| // hack for tools.jar dependency issue in jolokia-jvm | |||
There was a problem hiding this comment.
A TODO stating that the code block should be removed once it's fixed in the jolokia-jvm could be useful.
tadayosi
force-pushed
the
Issue-2593-jolokia-upgrade
branch
from
a618c74 to
ceb4997
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2593
Release Note