-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed the deprecated --logging-level option (issue #2000) #2377
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need to rebase camel-main on main at some point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love reviewing "delete only" PR 😉!
+1. I think we need to do it this week to not get too far behind on camel-main |
Yeah, here and on camel-k-runtime |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice cleaning work. I think we should include some documentation though in order to let the people know how to use/edit the logging trait. If we have it missing at all, we should take the opportunity and add a little entry (maybe under running/log menu section) explaining how to do that.
Thanks. We actually have the Maybe we should make it more easily accessible in the home page? |
I'd suggest to create a "Logging" page, under the "Observability" one, along with the existing monitoring documentation: https://camel.apache.org/camel-k/latest/observability/monitoring.html. At least that was the original intent of the "Observability" section, grouping Logging, Monitoring, and Tracing. |
Yeah, I think we should have a dedicated section that will link to the log trait page as well. I'd say a short entry under /running/log would be enough for now. EDIT: as suggested by @astefanutti also an entry in the Observability could be good. |
@astefanutti @squakez Thanks. Let me add the documentation as part of this PR before we merge this. I'm also wondering if we should include some simpler/smaller version of this as well: https://camel.apache.org/blog/2021/05/new-camel-k-logging-features/. If you have any suggestions, please let me know :) |
Thanks @orpiske, I think a short version with basic info should be okey. From there you can add a link to the trait page where we explain more in details all those aspects. |
@orpiske the content from https://camel.apache.org/blog/2021/05/new-camel-k-logging-features would be exactly what's needed. I'd suggest to mimic the existing organisation from the monitoring documentation, that is two pages, Operator and Integration, within Observability > Logging. Also a link from the |
97f4ad2
to
7c574b0
Compare
Added a bit of documentation. |
Awesome, thanks @orpiske! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Release Note