Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(e2e): remove duplicate test in knative tests #2372

Merged
merged 1 commit into from
Jun 8, 2021
Merged

chore(e2e): remove duplicate test in knative tests #2372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions e2e/knative/knative_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,19 +56,6 @@ func TestRunServiceCombo(t *testing.T) {
})
}

func TestRunChannelComboV1Alpha1(t *testing.T) {
WithNewTestNamespace(t, func(ns string) {
Expect(CreateKnativeChannelv1Alpha1(ns, "messages")()).To(Succeed())
Expect(Kamel("install", "-n", ns, "--trait-profile", "knative").Execute()).To(Succeed())
Expect(Kamel("run", "-n", ns, "files/knativech2.groovy").Execute()).To(Succeed())
Expect(Kamel("run", "-n", ns, "files/knativech1.groovy").Execute()).To(Succeed())
Eventually(IntegrationPodPhase(ns, "knativech2"), TestTimeoutLong).Should(Equal(v1.PodRunning))
Eventually(IntegrationPodPhase(ns, "knativech1"), TestTimeoutLong).Should(Equal(v1.PodRunning))
Eventually(IntegrationLogs(ns, "knativech2"), TestTimeoutMedium).Should(ContainSubstring("Received: Hello from knativech1"))
Expect(Kamel("delete", "--all", "-n", ns).Execute()).To(Succeed())
})
}

func TestRunChannelComboV1Beta1(t *testing.T) {
WithNewTestNamespace(t, func(ns string) {
Expect(CreateKnativeChannelv1Beta1(ns, "messages")()).To(Succeed())
Expand Down
16 changes: 0 additions & 16 deletions e2e/support/test_support.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1021,22 +1021,6 @@ func CreateKamelPod(ns string, name string, command ...string) error {
Knative
*/

func CreateKnativeChannelv1Alpha1(ns string, name string) func() error {
return func() error {
channel := messaging.InMemoryChannel{
TypeMeta: metav1.TypeMeta{
Kind: "InMemoryChannel",
APIVersion: messaging.SchemeGroupVersion.String(),
},
ObjectMeta: metav1.ObjectMeta{
Namespace: ns,
Name: name,
},
}
return TestClient().Create(TestContext, &channel)
}
}

func CreateKnativeChannelv1Beta1(ns string, name string) func() error {
return func() error {
channel := messaging.InMemoryChannel{
Expand Down