-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it possible to define the container image without IntegrationKit #2360
Conversation
Thinking out loud, I wonder whether we could skip the creation of the kit altogether, by setting the Integration |
Yep, that would be an option however I wasn't sure if the IntegrationKit is maybe referenced somewhere in the processing pipeline |
@astefanutti so yes, at the moment the IntegrationKit is likely needed as the environment requires it and some of the trait expect it to be defined i.e. to borrow configurations & so on so we may need a deep refactor if we want to have an option to entirely skip it. |
The opposite would have been surprising :) It should be fine to do it in two steps, and implement the kitless approach in a second issue. Even after an upgrade to the later version, the Integration should work seamlessly. |
Now if we decide to stick to the proposed approach, would enlisting the IntegrationKit into the environment resources, and let the deployer trait apply it work, instead of creating it explicitly? |
We really need to sit down ad rethink a little how traits are implemented, guess there is room for improvement. |
5ea06af
to
534f5f2
Compare
Partial implementation of #2232 |
534f5f2
to
89c4eab
Compare
Release Note