Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Tidy proposals directory #2204

Merged
merged 2 commits into from
Apr 12, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ on:
- master
- "release-*"
paths-ignore:
- 'proposals/**'
- '**.adoc'
- 'KEYS'
- 'LICENSE'
Expand All @@ -32,6 +33,7 @@ on:
- master
- "release-*"
paths-ignore:
- 'proposals/**'
- '**.adoc'
- 'KEYS'
- 'LICENSE'
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/builder.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ on:
- master
- "release-*"
paths-ignore:
- 'proposals/**'
- '**.adoc'
- 'KEYS'
- 'LICENSE'
Expand All @@ -32,6 +33,7 @@ on:
- master
- "release-*"
paths-ignore:
- 'proposals/**'
- '**.adoc'
- 'KEYS'
- 'LICENSE'
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/knative.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ on:
- master
- "release-*"
paths-ignore:
- 'proposals/**'
- '**.adoc'
- 'KEYS'
- 'LICENSE'
Expand All @@ -32,6 +33,7 @@ on:
- master
- "release-*"
paths-ignore:
- 'proposals/**'
- '**.adoc'
- 'KEYS'
- 'LICENSE'
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/kubernetes.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ on:
- master
- "release-*"
paths-ignore:
- 'proposals/**'
- '**.adoc'
- 'KEYS'
- 'LICENSE'
Expand All @@ -32,6 +33,7 @@ on:
- master
- "release-*"
paths-ignore:
- 'proposals/**'
- '**.adoc'
- 'KEYS'
- 'LICENSE'
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/local.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ on:
- master
- "release-*"
paths-ignore:
- 'proposals/**'
- '**.adoc'
- 'KEYS'
- 'LICENSE'
Expand All @@ -32,6 +33,7 @@ on:
- master
- "release-*"
paths-ignore:
- 'proposals/**'
- '**.adoc'
- 'KEYS'
- 'LICENSE'
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/openshift.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ on:
- master
- "release-*"
paths-ignore:
- 'proposals/**'
- '**.adoc'
- 'KEYS'
- 'LICENSE'
Expand All @@ -32,6 +33,7 @@ on:
- master
- "release-*"
paths-ignore:
- 'proposals/**'
- '**.adoc'
- 'KEYS'
- 'LICENSE'
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/upgrade.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ on:
- master
- "release-*"
paths-ignore:
- 'proposals/**'
- '**.adoc'
- 'KEYS'
- 'LICENSE'
Expand All @@ -32,6 +33,7 @@ on:
- master
- "release-*"
paths-ignore:
- 'proposals/**'
- '**.adoc'
- 'KEYS'
- 'LICENSE'
Expand Down
123 changes: 123 additions & 0 deletions proposals/service-binding.adoc
Original file line number Diff line number Diff line change
@@ -0,0 +1,123 @@
---
title: Service Binding
authors:
- "@johnpoth"
reviewers:
- "@lburgazzoli"
approvers:
- TBD
creation-date: 2020-15-12
last-updated: 2020-15-12
status: implementable
see-also: []
replaces: []
superseded-by: []
---

[[service-binding]]
= Service Binding

== Summary

This proposal aims at leveraging the https://github.com/k8s-service-bindings/spec#service-binding[Service Binding Specification] in Camel K.

=== Terminology

* _Provisioned Service_
** A service e.g. a Database, or a Broker that can be _bound_ to an application by means defined in the https://github.com/k8s-service-bindings/spec#provisioned-service[specification]
* _Application_
** In the context of Camel K is an `Integration`

== Motivation

Users should be able to connect to a _Provisioned Service_ by specifying one or more __Service Binding__s from the command line, e.g.:

[source,console]
----
$ kamel run intergration --connect database,broker
----

The _Service Binding_ could be referenced by name like shown above, in which case the _Service Binding_ already exists, or it could be created and managed by Camel K in which case the user would have to explicitly specify the _Provisioned Service_ they want to connect to:

[source,console]
----
$ kamel run intergration --connect Database.v1alpha1.postgresql.baiju.dev/db-demo
----

The user may then reference the binding properties inside the integration just like any other properties.

== Goals

The goal of this proposal is to provide the current state of the https://github.com/k8s-service-bindings/spec#service-binding[Service Binding Specification] and how it might be leveraged in Camel K to ease route configuration and facilitate their re-usability.

== Context

The specification can be split into two categories: the _Service Binding Operator_, and the _Provisioned Service_ implementation.
Several implementations of the _Service Binding Operator_ can be found readily available.

Two have been tried in the context of this proposal:

* https://github.com/vmware-labs/service-bindings
* https://github.com/redhat-developer/service-binding-operator.

_Provisioned Services_ implementations are still work in progress and aren't readily available.
A list of https://github.com/k8s-service-bindings/spec/issues/16[first] and https://github.com/k8s-service-bindings/spec/issues/19[second] wave of specification adopters is maintained. Knowing this, usability of the `Service Binding Specification` remains limited.
However, an initial effort may be done in order to better understand how Camel K can benefit from it.

=== Workflow

Two main workflows have been identified in the specification that allows user applications to bind to a _Provisioned Service_.
Let's review them and see which one would suit Camel K the best.

The first way outlined in the specification is for the user to create a `ServiceBinding` indicating which _application_ to bind to which set of _Provisioned Services_:

[source,yaml]
----
kind: ServiceBinding
metadata:
name: account-service
spec:
application:
apiVersion: apps/v1
kind: Deployment
name: camel-k-integration

service:
apiVersion: com.example/v1alpha1
kind: Database
name: my-database
----

Once created, it is the responsibility of the _Service Binding Operator_ to inject the binding information into the _application_.
The _application_ is any `PodSpec`-able resource e.g a `Deployment`.
The way it does this is that it first scales the `Deployment` down to 0.
Then it injects the binding information into the `Deployment` in the form of a `Secret` or a `ConfigMap`.
Finally, it scales the `Deployment` back up.

The second way is through https://github.com/k8s-service-bindings/spec#custom-projection-service-binding-example-resource[Custom Projection].
The difference between this approach, and the first one is that the binding information injection into the _application_ is not the responsibility of the _Service Binding Operator_ anymore.
It wil be the responsibility of another Operator. In our case it will be Camel K's responsibility to retrieve the binding information and inject it into the `Integration`.

The drawback of the first approach, in the context of Camel K, is that the ``Integration``'s `Deployment` would be created in an incomplete state and would result in an error the first time the underlying container is started because the binding information is not present.
The second drawback is that the ``Integration``'s `Deployment` resource should ideally _not_ be altered by someone other than the Camel K operator itself.
The advantage of using this approach is that less work is needed in Camel K as injection is taken care of by the _Service Binding Operator_.

Conversely, the drawback of implementing the second approach is that more work is needed as Camel K would have to retrieve and inject the binding information.
The advantage would be that Camel K retains full control of the ``Integration``'s `Deployment/Cron/Knative` resource, and we can delay the startup until the binding information is available.

For these reasons, it seems that the second approach is preferred in the context of Camel K.

== Proposal

=== Architecture

The proposed architecture is illustrated in the diagram below:

image::assets/service-binding.svg[Camel K Integration Service Binding]

where the `Secret` created by the _Service Binding Operator_ holds the binding information. Quarkus' Service Binding https://github.com/quarkusio/quarkus/issues/13617[support] could then be leveraged to configure the `Integration`.

The steps `2-4` would not happen if the `ServiceBinding` is created beforehand.

In the Optional steps `2-4`, Camel K will have to wait until the `ServiceBinding` is injected with the `Secret`.
To avoid useless reconciliation loops, a new `Phase` would be added (e.g. `IntegrationPhaseWaitingForServiceBinding`) which would pause the integration until Camel K is notified of a change in the `ServiceBinding`.
101 changes: 0 additions & 101 deletions proposals/service-binding/service-binding.adoc

This file was deleted.