Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add tests for kamel describe #2176

Closed
wants to merge 1 commit into from

Conversation

mmajerni
Copy link
Contributor

PR for: https://issues.redhat.com/browse/FUSEQE-12069

Merge after #2126 (Because of GetOutputString())

Release Note

NONE

@vsokolovskii
Copy link
Contributor

merge after #2422

@astefanutti
Copy link
Member

#2422 has been merged, could you rebase that one? Thanks.

@astefanutti astefanutti added the area/cli Kamel CLI label Jun 22, 2021
@mmajerni
Copy link
Contributor Author

@astefanutti done, rebased ^^

})

t.Run("Test kamel describe integration kit", func(t *testing.T) {
kitName := Integration(ns, "yaml")().Status.Kit
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I know this way of getting the kit name is deprecated, so I'd recommend to use this one:

kitName := Integration(ns, "yaml")().Status.IntegrationKit.Name

@vsokolovskii
Copy link
Contributor

Since !2495 was closed the redirection of kamel describe command output works now.

@vsokolovskii
Copy link
Contributor

vsokolovskii commented Oct 25, 2021

@oscerd Could you please close it? These changes were delivered in #2680

@oscerd oscerd closed this Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli Kamel CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants