Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: add in/out/error type schema to v1alpha1.Endpoint #1852

Merged
merged 1 commit into from
Dec 9, 2020
Merged

api: add in/out/error type schema to v1alpha1.Endpoint #1852

merged 1 commit into from
Dec 9, 2020

Conversation

lburgazzoli
Copy link
Contributor

Release Note

NONE

astefanutti
astefanutti approved these changes Dec 9, 2020
View reviewed changes
Copy link
Member

@astefanutti astefanutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the CRD be regenerated?

pkg/apis/camel/v1alpha1/kamelet_binding_types.go Outdated Show resolved Hide resolved
@lburgazzoli
Copy link
Contributor Author

Should the CRD be regenerated?

I can but on my side it does re-format each yaml ... maybe someone of you can do it once merged while I'm trying to understand what is the reason

@lburgazzoli lburgazzoli merged commit 77b8323 into apache:master Dec 9, 2020
@lburgazzoli lburgazzoli deleted the binding-types branch December 9, 2020 16:12
@astefanutti astefanutti mentioned this pull request Dec 9, 2020
Merged
@nicolaferraro nicolaferraro mentioned this pull request Dec 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscerd oscerd oscerd approved these changes

@nicolaferraro nicolaferraro nicolaferraro approved these changes

@astefanutti astefanutti astefanutti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lburgazzoli @astefanutti @nicolaferraro @oscerd