Create PodDisruptionBudget for every integration

[mmelko]

Closes: #1760

This is what I have so far. PDB is created for every integration and deleted with integration. I decided to go with new trait for the PDB but I can refactor if necessary.

I still need to create test for the trait and also I'm not sure if IntegrationRunning phase is the best here. Any feedback appreciated.

Release Note

feat: Configure PodDisruptionBudget for integrations

[mmelko]

@astefanutti @lburgazzoli @nicolaferraro FYI

[astefanutti]

I think permissions to get, create, update the PDB resources must be added to the operator RBAC.

[mmelko]

Should that be in operator-role-kubernetes/openshift,yaml file ?

[astefanutti]

Should that be in operator-role-kubernetes/openshift,yaml file ?

Exactly, and the generated resources, like the OLM CSV updated accordingly.

[mmelko]

I've tested this also with knative and cron-job deployment strategies and it works as expected.

[astefanutti]

@lburgazzoli @nicolaferraro 👋,

That PR introduces the pod trait, whose purpose is to be responsible for all the aspects that directly relate to the integration pods configuration. That includes upcoming work to support:

• Tolerations
• Pod topology spread
• Pod template, either inlined or by referencing a ConfigMap, addressing Fix #1670: upgrade to Knative 0.16 and support from 0.15 to 0.17 #1685 Add support for podtemplatespec / container in the Integration CRD #1657.

Technically, the affinity trait should be merged into that new trait, yet we may want to keep that concern separated, at least to maintain compatibility for the 1.x lifespan.

It turns out we already have traits responsible for the container and deployment aspects, but none for those of the pods. The deployment trait could have been a candidate to meet that need. However it's specific to the Deployment strategy, while the pod aspects can be shared across deployment strategies.

WDYT?

[lburgazzoli]

I guess this also relates to: #1657

[astefanutti]

I guess this also relates to: #1657

Damn auto-complete, that's the one I wanted to type. Corrected my previous comment.

[lburgazzoli]

I'm thinking if after we'll have #1657, we should reduce the number of traits to the bare minimum and with a very opinionated list of what can be configured via traits and leave everything else to pod templates & co

[lburgazzoli]

maybe also have a flag to use a pod tamplate from a local yaml

[astefanutti]

After thinking a bit based on this discussion, I'd suggest we introduce a pdb trait for the sole scope of that PR, and start working on the new pod trait to address #1657, and see what other options it could be responsible for.

[mmelko]

I refactored it back to pdb trait.