-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test] Create integration test for exposing metrics to prometheus #1660
Conversation
@astefanutti please review |
0c9e674
to
ba182c2
Compare
@astefanutti Shouldn't i use |
<dependency> | ||
<groupId>org.apache.camel.quarkus</groupId> | ||
<artifactId>camel-quarkus-microprofile-metrics</artifactId> | ||
<version>1.0.0-CR2</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@astefanutti Any idea how we could keep this up to date ?
The Prometheus trait also works with vanilla Kubernetes, so it should ideally be tested also. The assertions will probably have to be different, as for vanilla Kubernetes Thanos is not a pre-requisite. It is fine to use |
@@ -0,0 +1,4 @@ | |||
jdk: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally the tests would not depend on Jitpack. Unfortunately, the service bean has to be compiled beforehand and provided as an external bean archive JAR, so it has to be served from a Maven repository.
@astefanutti Do you know why the travis failed ? |
@llowinge I've restarted the tests. It failed because of a connection timeout. |
e2e/yaks/monitoring/app/src/main/java/com/redhat/integration/Service.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This is basic test scenario covering https://issues.redhat.com/browse/ENTESB-13667.
Release Note