Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1364: only delete direct children of the integration during gc #1372

Merged
merged 1 commit into from
Mar 25, 2020
Merged

Fix #1364: only delete direct children of the integration during gc #1372

merged 1 commit into from
Mar 25, 2020

Conversation

nicolaferraro
Copy link
Member

@nicolaferraro nicolaferraro commented Mar 24, 2020 •
edited
Loading

Fix #1364

This limits the GC deletion only to direct children of the integration resource, to avoid the unwanted deletion of Knative revisions and other sub-resources.

Release Note

Improved stability of Knative services by removing code that interfered with Knative controllers

@nicolaferraro nicolaferraro added the kind/bug Something isn't working label Mar 24, 2020
@nicolaferraro nicolaferraro merged commit dcb2b27 into apache:master Mar 25, 2020
@nicolaferraro nicolaferraro mentioned this pull request Jun 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscerd oscerd oscerd approved these changes

@astefanutti astefanutti astefanutti approved these changes

Assignees
No one assigned
Labels
kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Knative API example becomes unstable
3 participants
@nicolaferraro @astefanutti @oscerd