Integration status condition typo

[lsergio]

What happened?

Create a Rest Integration with knative trait enabled, like below:

apiVersion: camel.apache.org/v1
kind: Integration
metadata:
  name: deploy-fc949ea7-e5ea-4d59-8fed-83471b9350e0-381
spec:  
  sources:
  - name: main.yaml
    content: |-
      - from:
          uri: rest:get:/demo
          steps:
          - setBody:
              constant: "It worked"
  traits:
    knative-service:
      minScale: 1
    camel:
      runtimeVersion: 3.8.1

After the integration is running, check its status:

kubectl get it deploy-fc949ea7-e5ea-4d59-8fed-83471b9350e0-323 -oyaml

and look at the conditions to find:

  - lastTransitionTime: "2024-07-24T17:30:52Z"
    lastUpdateTime: "2024-07-24T17:30:52Z"
    message: 'controller strategy: knative-service'
    reason: DeploymentAvailable
    status: "False"
    type: DeploymentDeploymentAvailable

In Camel K 2.2, type used to be DeploymentAvailable only, whereas now it is DeploymentDeploymentAvailable.

I could not find any related change on the release notes, so I'm assuming this was not intentional. If this is by design, please just close it.

Steps to reproduce

No response

Relevant log output

No response

Camel K version

2.3.3

[lsergio]

A new scenario. Now when a quartz integration is created:

apiVersion: camel.apache.org/v1
kind: Integration
metadata:
  name: deploy-a41357e7-14c0-4a64-9933-80044f023ad3-381
spec:  
  sources:
  - name: main.yaml
    content: |-
      - from:
          uri: quartz://ipaas/trigger?cron=0+*+*+?+*+*
          steps:
          - log:
              message: "It worked"
  traits:
    camel:
      runtimeVersion: 3.8.1
    cron:
      fallback: true

I see the conditions:

  - firstTruthyTime: "2024-07-24T18:42:31Z"
    lastTransitionTime: "2024-07-24T18:42:31Z"
    lastUpdateTime: "2024-07-24T18:42:31Z"
    message: deployment name is deploy-a41357e7-14c0-4a64-9933-80044f023ad3-323
    reason: DeploymentAvailable
    status: "True"
    type: DeploymentAvailable <-- DeploymentAvailable and not DeploymentDeploymentAvailable (when status is True)
  - lastTransitionTime: "2024-07-24T18:42:31Z"
    lastUpdateTime: "2024-07-24T18:42:31Z"
    message: different controller strategy used (deployment)
    reason: KnativeServiceNotAvailable
    status: "False"
    type: KnativeServiceKnativeServiceAvailable <-- KnativeService prefix duplicated
  - lastTransitionTime: "2024-07-24T18:42:31Z"
    lastUpdateTime: "2024-07-24T18:42:31Z"
    message: fallback strategy selected
    reason: CronJobNotAvailableReason
    status: "False"
    type: CronCronJobAvailable <-- Cron prefix duplicated

It seems like the related Trait name is being prefixed to the type value when the status is False.

[lsergio]

I see that in https://github.com/apache/camel-k/blob/release-2.3.x/pkg/trait/trait_condition_types.go#L79 the traitId is being prefixed to the condition.
Trying to understand why the trait Id is not being prefixed here:

- firstTruthyTime: "2024-07-24T18:42:31Z"
    lastTransitionTime: "2024-07-24T18:42:31Z"
    lastUpdateTime: "2024-07-24T18:42:31Z"
    message: deployment name is deploy-a41357e7-14c0-4a64-9933-80044f023ad3-323
    reason: DeploymentAvailable
    status: "True"
    type: DeploymentAvailable <-- DeploymentAvailable and not DeploymentDeploymentAvailable (when status is True)

[lsergio]

Here is where the condition is set for the scenario in the previous comment, where the prefix is not added.

[lsergio]

Hi @squakez . If the expected behavior is to not have the trait id prefix, I can work on that and even backport it to release-2.3.x so that 2.3.4 has the fix as well.

[squakez]

Yes please. The presence of the trait id prefix is an helper to manage more easily any generic case. The final result has to be without the duplication. If you can work on it before next week it would be good so we can include in 2.4.0 (#5678), thanks.

[lsergio]

Hi @squakez . I see that 2.4.0 has just been released, but it says "This is the development version of Camel K. It should not be used in production.".
Considering that, is there a plan for releasing 2.3.4 to have this bug fixed?

[squakez]

Hi @squakez . I see that 2.4.0 has just been released, but it says "This is the development version of Camel K. It should not be used in production.". Considering that, is there a plan for releasing 2.3.4 to have this bug fixed?

Ouch. That must be a documentation issue, thanks for reporting. The version is supposed to be final and stable. I'll fix it straight away the doc. Unless there is any CVE to patch or major blocker, now that 2.4 is out we won't release 2.3.x any longer.