Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add license header file check workflow on PR in CI #5631

Closed
gansheer opened this issue Jun 13, 2024 · 1 comment
Closed

Add license header file check workflow on PR in CI #5631

gansheer opened this issue Jun 13, 2024 · 1 comment
Assignees
@gansheer
Labels
area/continuous integration Related to CI and automated testing good first issue Does not require full understanding of the codebase

Comments

@gansheer
Copy link
Contributor

Requirement

We need to ensure the project does not contains files without the Apache license.

Problem

We have a recurring issue on release where we have some licenses missing (#5603, #5433, ...).

Proposal

We nedd to add the license check workflow in our CI PR process using the make check-licenses command.

Open questions

No response
@gansheer gansheer added kind/feature New feature or request area/continuous integration Related to CI and automated testing labels Jun 13, 2024
@squakez squakez removed the kind/feature New feature or request label Jun 13, 2024
@squakez
Copy link
Contributor

squakez commented Jun 13, 2024

It could be another task in the validate workflow.

@squakez squakez added the good first issue Does not require full understanding of the codebase label Jun 13, 2024
@gansheer gansheer self-assigned this Jun 14, 2024
@gansheer gansheer mentioned this issue Jun 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gansheer gansheer

Labels
area/continuous integration Related to CI and automated testing good first issue Does not require full understanding of the codebase
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gansheer @squakez