Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing license header files #5433

Closed
squakez opened this issue Apr 29, 2024 · 3 comments · Fixed by #5442
Closed

Missing license header files #5433

squakez opened this issue Apr 29, 2024 · 3 comments · Fixed by #5442
Assignees
Labels
area/continuous integration Related to CI and automated testing

Comments

@squakez
Copy link
Contributor

squakez commented Apr 29, 2024

file ./e2e/advanced/files/deploy.yaml does not contain license
file ./.github/workflows/comment-pr.yaml does not contain license
@squakez squakez added the area/continuous integration Related to CI and automated testing label Apr 29, 2024
@gansheer gansheer self-assigned this Apr 30, 2024
@gansheer
Copy link
Contributor

gansheer commented Apr 30, 2024

How did you find these ? I ran the check_licenses.sh script and it did not see these files.

@squakez
Copy link
Contributor Author

squakez commented Apr 30, 2024

How did you find these ? I ran the check_licenses.sh script and it did not see these files.

During release process. I think it is the same script, but not sure 100%.

@gansheer
Copy link
Contributor

gansheer commented Apr 30, 2024

Ok, I found my issue, I have some temp files without license so it block the full code scan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/continuous integration Related to CI and automated testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants