Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to define K8s toleration for Builder pod #5354

Open
vkrejcirik opened this issue Apr 11, 2024 · 6 comments
Open

Ability to define K8s toleration for Builder pod #5354

vkrejcirik opened this issue Apr 11, 2024 · 6 comments
Assignees
Labels
area/traits kind/feature New feature or request
Milestone

Comments

@vkrejcirik
Copy link
Contributor

Requirement

I'm trying to define K8s toleration for Builder pod when using Native build. I want to dedicate nodes for Native builds. Builder trait allows to define node selector, but not toleration.

Problem

When having nodes with taints, I cannot schedule Builder pods on these nodes.

Proposal

I suggest adding new parameter to Builder trait which would allow adding toleration to the Builder pod.

Open questions

No response

@vkrejcirik vkrejcirik added the kind/feature New feature or request label Apr 11, 2024
@squakez
Copy link
Contributor

squakez commented Apr 11, 2024

Thanks for reporting. If you think you can contribute by any chance, just let us know.

@vkrejcirik
Copy link
Contributor Author

vkrejcirik commented Apr 12, 2024 via email

@squakez
Copy link
Contributor

squakez commented Apr 12, 2024

I think I can contribute on this one. Let me know if you can give me some more information where to start, it would speed up my work. Thanks, Vlad

Cool. So, probably you can mimic the work done in #4968 where we were adding the NodeSelector. The logic would be the same, but, with the new field instead. Feel free to ask any support here or in zulip chat [1] where we can have a quicker interaction.

[1] https://camel.zulipchat.com/#narrow/stream/257299-camel-k

@vkrejcirik
Copy link
Contributor Author

@squakez I will look into this one if that's okay.

@squakez squakez added this to the 2.4.0 milestone Apr 22, 2024
@vkrejcirik
Copy link
Contributor Author

I'm just starting to work on this one..

@squakez squakez modified the milestones: 2.4.0, 2.5.0 Jul 30, 2024
@squakez squakez removed this from the 2.5.0 milestone Oct 21, 2024
@squakez squakez added this to the 2.6.0 milestone Dec 3, 2024
@squakez
Copy link
Contributor

squakez commented Dec 3, 2024

Hello @vkrejcirik are you still actively working on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/traits kind/feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants