-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Knative installation check is wrong #4962
Comments
I guess it is better to just resolve the "addressable", for the sink address? |
(of course installing serving "fixes" it) |
thanks @matzew! yes, makes sense we should improve the Knative installation check one more thing. please be careful to reference my fork (christophd) of the camel-k repository 😄 it might not be up-to-date all the time 😁 |
Oh, I have not noticed this - I came there via Github code search 🤣 |
We should probably add the eventing to https://github.com/apache/camel-k/blob/main/pkg/util/knative/apis.go#L138 |
Hi all |
See #5402 |
What happened?
I have Knative Eventing installed, but b/c of how the code is written, the
knative.IsInstalled
check inknative_ref.go
is returningfalse
https://github.com/christophd/camel-k/blob/169b7a15901e3a04b094544ee359da19a6931c7b/pkg/util/bindings/knative_ref.go#L56
See here:
https://github.com/apache/camel-k/blob/main/pkg/util/test/client.go#L207-L213
It just checks for "serving", which is only one part of Knative. Eventing can be installed w/o serving
Steps to reproduce
No response
Relevant log output
The text was updated successfully, but these errors were encountered: