Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use generated trait #4811

Closed
squakez opened this issue Oct 9, 2023 · 2 comments · Fixed by #5153
Closed

Use generated trait #4811

squakez opened this issue Oct 9, 2023 · 2 comments · Fixed by #5153

Comments

@squakez
Copy link
Contributor

squakez commented Oct 9, 2023

With #4764 we have simplified the managment of native builder execution. However we're not using a best practice as the operator alter the configuration .spec of builder trait by adding something that will be required at build time. In order to follow best practices, we should instead move the generated configuration into the .status.

Ideally, we should have a .status.traits parameter where we copied the .spec.traits and additionally include any operator generated configuration.

@squakez squakez added kind/feature New feature or request area/traits and removed kind/feature New feature or request labels Oct 9, 2023
Copy link
Contributor

github-actions bot commented Jan 8, 2024

This issue has been automatically marked as stale due to 90 days of inactivity.
It will be closed if no further activity occurs within 15 days.
If you think that’s incorrect or the issue should never stale, please simply write any comment.
Thanks for your contributions!

@squakez squakez self-assigned this Feb 12, 2024
@squakez squakez added this to the 2.3.0 milestone Feb 12, 2024
squakez added a commit to squakez/camel-k that referenced this issue Feb 12, 2024
squakez added a commit that referenced this issue Feb 13, 2024
realMartinez pushed a commit to realMartinez/camel-k that referenced this issue Feb 29, 2024
realMartinez pushed a commit to realMartinez/camel-k that referenced this issue Feb 29, 2024
realMartinez pushed a commit to realMartinez/camel-k that referenced this issue Feb 29, 2024
realMartinez pushed a commit to realMartinez/camel-k that referenced this issue Feb 29, 2024
@squakez
Copy link
Contributor Author

squakez commented Mar 8, 2024

Mind that #5233 reverts this feature development. Please, see the PR details to understand why this feature cannot be really developed and the alternative to check any value which may have been overridden by the operator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant