Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builder image name missing the organization configuration #4525

Closed
gansheer opened this issue Jul 4, 2023 · 4 comments · Fixed by #4529
Closed

Builder image name missing the organization configuration #4525

gansheer opened this issue Jul 4, 2023 · 4 comments · Fixed by #4529
Assignees
Labels
kind/bug Something isn't working
Milestone

Comments

@gansheer
Copy link
Contributor

gansheer commented Jul 4, 2023

Version: Camel-k main branch (2.x)

When installing Camel-k with a defined organization id/name with build strategy pod the builder image full name does not contains the organization id/name. I think it should (like with the kit image):

REPOSITORY                                               TAG               IMAGE ID       CREATED          SIZE
apache/camel-k                                           2.0.0-SNAPSHOT    abda4a06c8c4   15 minutes ago   637MB
10.100.246.9/myorg/camel-k-kit-cihsu2p5tpl20drnif60   <none>            a18953b17581   2 weeks ago      516MB
10.100.246.9/camel-k-runtime-quarkus-builder             2.16.0-snapshot   0a3d865dd0dc   2 months ago     1.08GB

The command used to install is:

kamel install --build-strategy pod --organization  myorg
@squakez
Copy link
Contributor

squakez commented Jul 4, 2023

I don't think the org should apply to the dynamic image builder. IMO we need the builder to be as much generic as possible and reused if we have several IntegrationPlatforms (hence, several organizations).

@gansheer
Copy link
Contributor Author

gansheer commented Jul 4, 2023

What will happen if we have non-compatible registry configurations (example with auth) in different IntegrationPlatforms ? Do we generate a another builder image ?

@squakez
Copy link
Contributor

squakez commented Jul 4, 2023

What will happen if we have non-compatible registry configurations (example with auth) in different IntegrationPlatforms ? Do we generate a another builder image ?

Good point. In general we need to revisit the entire concept of the dynamic builder, which is something that may be just temporary. If we evaluate for now it requires some enhancement like the one you're proposing, probably it makes sense to do it. Thanks.

@squakez squakez self-assigned this Jul 4, 2023
@squakez
Copy link
Contributor

squakez commented Jul 4, 2023

Trying to use a private registry we're getting some auth problems:

      message: 'HEAD https://index.docker.io/v2/library/camel-k-runtime-quarkus-builder/manifests/2.16.0-snapshot:
        unexpected status code 401 Unauthorized (HEAD responses have no body, use
        GET for details)'

@squakez squakez added the kind/bug Something isn't working label Jul 4, 2023
@squakez squakez added this to the 2.0.0 milestone Jul 4, 2023
squakez added a commit to squakez/camel-k that referenced this issue Jul 4, 2023
squakez added a commit that referenced this issue Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants