Acquiring lock at startup is taking long

[squakez]

I recall the lock acquiring used to take long some release ago. Now, it seems again it takes like 15 seconds, which I think it's longer than it should:

camel-k-operator-6844754cc8-98bw7 camel-k-operator {"level":"info","ts":1681297670.2073886,"logger":"camel-k.cmd","msg":"attempting to acquire leader lease default/camel-k-lock...\n"}
camel-k-operator-6844754cc8-98bw7 camel-k-operator {"level":"info","ts":1681297685.6172009,"logger":"camel-k.cmd","msg":"successfully acquired lease default/camel-k-lock\n"}

We need to put an eye on it.

[squakez]

It seems this is because we're failing to release the lease, so it waits the canonical 15 seconds to make sure the previous master is not alive, and it happens when a previous Lease was present on the namespace. When we shutdown the operator, we can see we have some error:

camel-k-operator-6844754cc8-kj76g camel-k-operator {"level":"info","ts":1681395538.729762,"msg":"Wait completed, proceeding to shutdown the manager"}
camel-k-operator-6844754cc8-kj76g camel-k-operator {"level":"error","ts":1681395538.7311943,"logger":"camel-k.cmd","msg":"Failed to release lock: leases.coordination.k8s.io \"camel-k-lock\" is forbidden: User \"system:serviceaccount:default:camel-k-operator\" cannot update resource \"leases\" in API group \"coordination.k8s.io\" in the namespace \"default\"\n","stacktrace":"k8s.io/klog/v2.(*loggingT).output\n\tk8s.io/klog/[email protected]/klog.go:877\nk8s.io/klog/v2.(*loggingT).printfDepth\n\tk8s.io/klog/[email protected]/klog.go:739\nk8s.io/klog/v2.(*loggingT).printf\n\tk8s.io/klog/[email protected]/klog.go:721\nk8s.io/klog/v2.Errorf\n\tk8s.io/klog/[email protected]/klog.go:1555\nk8s.io/client-go/tools/leaderelection.(*LeaderElector).release\n\tk8s.io/[email protected]/tools/leaderelection/leaderelection.go:306\nk8s.io/client-go/tools/leaderelection.(*LeaderElector).renew\n\tk8s.io/[email protected]/tools/leaderelection/leaderelection.go:289\nk8s.io/client-go/tools/leaderelection.(*LeaderElector).Run\n\tk8s.io/[email protected]/tools/leaderelection/leaderelection.go:212\nsigs.k8s.io/controller-runtime/pkg/manager.(*controllerManager).startLeaderElection.func3\n\tsigs.k8s.io/[email protected]/pkg/manager/internal.go:647"}
camel-k-operator-6844754cc8-kj76g camel-k-operator {"level":"error","ts":1681395538.7313108,"msg":"error received after stop sequence was engaged","error":"leader election lost","stacktrace":"sigs.k8s.io/controller-runtime/pkg/manager.(*controllerManager).engageStopProcedure.func1\n\tsigs.k8s.io/[email protected]/pkg/manager/internal.go:545"}

We need to fix this one and make sure the Lease is released when the manager stops.