Failing integration does not report error condition

[squakez]

Any failing integration, ie kamel run -d mvn:com.example:nonexistent:1.0 Hello.java will correctly set the error on IntegrationKit, but won't do on Integration, resulting the Integration in a Building Kit state even if it failed:

squake:~ $ kamel get
NAME	PHASE		KIT
hello	Building Kit	default/kit-cb19gvc268e9p6peapt0

squake:~ $ k get integrationkit
NAME                       PHASE   TYPE       IMAGE
kit-cb19gvc268e9p6peapt0   Error   platform 

[squakez]

Hey @astefanutti, I had a first look at this, but I am not able to figure it out where it is failing. Do you have some suggestion to places I should look for a fix? I had a look at the code and I think that error conditions should be captured by

camel-k/pkg/controller/integration/build_kit.go

Line 91 in 37cba2f

if kit.Status.Phase == v1.IntegrationKitPhaseError {

, although it's not. Thanks in advance for the support.

[tadayosi]

Is this somewhere like this that is relevant to the issue?
https://github.com/apache/camel-k/blob/main/pkg/controller/integration/monitor.go#L218

[squakez]

Is this somewhere like this that is relevant to the issue? https://github.com/apache/camel-k/blob/main/pkg/controller/integration/monitor.go#L218

Thanks @tadayosi. I am not sure what is the expected behavior. I mean, I'm assuming that a failing IntegrationKit build will take care to turn the Integration which owns it as errored as well but I don't know where it used to happen. There were several refactoring in the past, so, likely we missed something. Also we need to introduce an E2E test to take care of this situation and avoid any future regression.

[astefanutti]

@squakez as you pointed it out, the integration phase is set to error when the kit fails in:

camel-k/pkg/controller/integration/build_kit.go

Line 91 in 37cba2f

if kit.Status.Phase == v1.IntegrationKitPhaseError {

I suspect this works, but the integration phase gets overwritten later with:

camel-k/pkg/controller/integration/monitor.go

Line 230 in c3b9c9b

integration.Status.Phase = v1.IntegrationPhaseRunning

For some reasons, the phase is not set to error while introspecting the underlying deployment / pods. That being said, it may be more robust to force the phase to error in that case, which would likely provide a better error message.

[squakez]

I've gone deep in this and found the responsible is this check here:

camel-k/pkg/controller/integration/kits.go

Lines 117 to 121 in 132dceb

	func statusMatches(integration *v1.Integration, kit *v1.IntegrationKit, ilog *log.Logger) bool {
	if kit.Status.Phase == v1.IntegrationKitPhaseError {
	ilog.Debug("Integration kit has a phase of Error", "integration-kit", kit.Name, "namespace", integration.Namespace)
	return false
	}

Basically we never found a match when the integrationkit has failed, resulting in the issue described. Unfortunately the method is used in other places, so I will need to find a way to solve it.