Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standard/Incremental build option #3011

Closed
squakez opened this issue Feb 15, 2022 · 1 comment · Fixed by #4816
Closed

Standard/Incremental build option #3011

squakez opened this issue Feb 15, 2022 · 1 comment · Fixed by #4816
Labels
area/build-operator Related to the internal image build operator status/never-stale

Comments

@squakez
Copy link
Contributor

squakez commented Feb 15, 2022

The logic to configure either "standard" or "incremental" should be done in the builder trait, where a configuration parameter could be added, and the corresponding build step added. It's a bit more subtle than that, because "incremental" image build step should be deactivated for Quarkus native build, from the quarkus trait, that already manipulates the build steps, but that should be quite straightforward.

There is also the following TODO that may be removed while we are at it:

// TODO: transient workaround to be removed in 1.8.x

Originally posted by @astefanutti in #3008 (comment)

@squakez squakez added the area/build-operator Related to the internal image build operator label Feb 24, 2022
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale due to 90 days of inactivity.
It will be closed if no further activity occurs within 15 days.
If you think that’s incorrect or the issue should never stale, please simply write any comment.
Thanks for your contributions!

squakez added a commit to squakez/camel-k that referenced this issue Oct 11, 2023
squakez added a commit to squakez/camel-k that referenced this issue Oct 11, 2023
squakez added a commit to squakez/camel-k that referenced this issue Oct 11, 2023
squakez added a commit to squakez/camel-k that referenced this issue Oct 11, 2023
squakez added a commit to squakez/camel-k that referenced this issue Oct 11, 2023
squakez added a commit that referenced this issue Oct 11, 2023
squakez added a commit that referenced this issue Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build-operator Related to the internal image build operator status/never-stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant