Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A better name for KameletBinding #2625

Closed
lburgazzoli opened this issue Sep 9, 2021 · 7 comments · Fixed by #4156
Closed

A better name for KameletBinding #2625

lburgazzoli opened this issue Sep 9, 2021 · 7 comments · Fixed by #4156

Comments

@lburgazzoli
Copy link
Contributor

When the KameletBinding concept was introduced in camel-k, if was meant to bind two Kamelets and nothing more, but over time we have added more capabilities, like:

  • support for processing steps to transform exchanges/messages
  • support to address/source from different systems so the source/sink does not need be a kamelet anymore

So I think the term KameletBinding is not more appropriate and to reduce confusion, following the discussion on the dev mailing list, we should rename KameletBinding to Binding

@nicolaferraro nicolaferraro added this to the 1.7.0 milestone Sep 9, 2021
@nicolaferraro nicolaferraro modified the milestones: 1.7.0, 1.8.0 Nov 15, 2021
@oscerd oscerd modified the milestones: 1.8.0, 1.9.0 Jan 19, 2022
@oscerd oscerd modified the milestones: 1.9.0, 1.9.1 Apr 26, 2022
@oscerd oscerd modified the milestones: 1.9.1, 1.9.2 May 13, 2022
@oscerd oscerd modified the milestones: 1.9.2, 2.0.0 May 23, 2022
@squakez
Copy link
Contributor

squakez commented Mar 10, 2023

@christophd since you're already making some work on Kamelets and we are discussing the opportunity to promote the Kamelets API to v1, I think it would be a good opportunity to have a look at this as well.

cc @oscerd @lburgazzoli

squakez added a commit to squakez/camel-k that referenced this issue Mar 23, 2023
squakez added a commit to squakez/camel-k that referenced this issue Mar 24, 2023
@squakez squakez self-assigned this Mar 27, 2023
squakez added a commit to squakez/camel-k that referenced this issue Mar 28, 2023
@squakez
Copy link
Contributor

squakez commented Apr 3, 2023

I've just realized the the CRD type "Binding" may not be a good name. When we try to get the CR from Kube we got some error:

squake:~/workspace/camel-k [feat/2625]$ k get bindings
Error from server (MethodNotAllowed): the server does not allow this method on the requested resource
squake:~/workspace/camel-k [feat/2625]$ k get bindings.camel.apache.org
No resources found in default namespace.
squake:~/workspace/camel-k [feat/2625]$ k get bd
No resources found in default namespace.

@lburgazzoli @astefanutti wdyt? IMO we are safe to use it, but it may create some problem in the future. Since we're still in time, maybe we can call it CamelBinding instead.

squakez added a commit to squakez/camel-k that referenced this issue Apr 3, 2023
squakez added a commit to squakez/camel-k that referenced this issue Apr 3, 2023
squakez added a commit to squakez/camel-k that referenced this issue Apr 4, 2023
@christophd
Copy link
Contributor

What about IntegrationBinding?

@christophd
Copy link
Contributor

I think we should avoid the name clash with the reserved K8s resource

@lburgazzoli
Copy link
Contributor Author

Maybe Pipe ?

@squakez
Copy link
Contributor

squakez commented Apr 4, 2023

I'm thinking on Bond

  • a connection between two surfaces or objects that have been joined together, especially by means of an adhesive substance, heat, or pressure.
  • (in construction) a pattern in which bricks are laid in order to ensure the strength of the resulting structure.

@squakez
Copy link
Contributor

squakez commented Apr 4, 2023

Finally, Pipe seems to be more appropriate and intuitive, let's go for it. Any objection, please feel free to add a comment.

squakez added a commit to squakez/camel-k that referenced this issue Apr 25, 2023
squakez added a commit to squakez/camel-k that referenced this issue Apr 26, 2023
squakez added a commit that referenced this issue Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants