Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration with Prometheus trait doesn't deploy on Minikube #1848

Closed
tadayosi opened this issue Dec 8, 2020 · 1 comment · Fixed by #1850
Closed

Integration with Prometheus trait doesn't deploy on Minikube #1848

tadayosi opened this issue Dec 8, 2020 · 1 comment · Fixed by #1850
Assignees
Labels
kind/bug Something isn't working

Comments

@tadayosi
Copy link
Member

tadayosi commented Dec 8, 2020

Prometheus trait works fine on OpenShift, but on Minikube I cannot finish running the following on Minikube even with or without prometheus.service-monitor:

kamel run examples/simple.js -t prometheus.enabled=true -t prometheus.service-monitor=false

It keeps Deploying forever:

$ kamel get
NAME	PHASE		KIT
simple	Deploying	kit-bv7h9harqm6v2qmd9890

Note the pod still runs fine and the service simple-prometheus is also created behind the scenes, but the phase never changes to Running.

Versions info:

$ kamel version 
Camel K Client 1.3.0-SNAPSHOT

$ minikube version 
minikube version: v1.15.1
commit: 23f40a012abb52eff365ff99a709501a61ac5876
@tadayosi
Copy link
Member Author

tadayosi commented Dec 9, 2020

As it turns out, it's an issue not only on Minikube but also on k8s in general and even on OCP 3.11 where ServiceMonitor CRD is not provided. The root cause is that some bool properties on traits are really not effective and thus prometheus.service-monitor=false is neglected. Pls see my pull req above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant