Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to set labels on knative service (for things like "cluster-local") #1712

Closed
makandre opened this issue Sep 24, 2020 · 5 comments
Closed
Labels

Comments

@makandre
Copy link

For from("knative:type/name") routes, we need ability to configure it so that the knative service that it creates would have certain labels. Particularly, need a way to apply serving.knative.dev/visibility=cluster-local label so my service would not be exposed publicly.

@makandre
Copy link
Author

makandre commented Sep 24, 2020

Workaround suggested by @nicolaferraro is to run with --label serving.knative.dev/visibility=cluster-local -t owner.target-labels=serving.knative.dev/visibility

But it doesn't seem to work, the label is applied but getting this error:

Revision creation failed with message: admission webhook
"validation.webhook.serving.knative.dev" denied the request: validation
failed: invalid key name "serving.knative.dev/visibility":
metadata.labels.

@vassilvk
Copy link

vassilvk commented Oct 20, 2020

@makandre, as a workaround you can create a KubeMod ModRule to intercept the service as it is being created by the operator and inject the necessary labels.

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale due to 90 days of inactivity.
It will be closed if no further activity occurs within 15 days.
If you think that’s incorrect or the issue should never stale, please simply write any comment.
Thanks for your contributions!

halmakidon added a commit to halmakidon/camel-k that referenced this issue Aug 14, 2022
Add visibility option to knative service trait.
halmakidon added a commit to halmakidon/camel-k that referenced this issue Aug 14, 2022
- Add visibility option to knative service trait.
- Extract creating test environment method for Knative service trait
halmakidon added a commit to halmakidon/camel-k that referenced this issue Aug 14, 2022
- Add visibility option to knative service trait.
- Extract creating test environment method for Knative service trait
halmakidon added a commit to halmakidon/camel-k that referenced this issue Aug 14, 2022
- Add visibility option to knative service trait.
- Extract creating test environment method for Knative service trait
halmakidon added a commit to halmakidon/camel-k that referenced this issue Aug 14, 2022
- Add visibility option to knative service trait.
- Extract creating test environment method for Knative service trait
tadayosi pushed a commit that referenced this issue Aug 18, 2022
- Add visibility option to knative service trait.
- Extract creating test environment method for Knative service trait
@halmakidon
Copy link
Contributor

This feature was released in v1.10.0.
https://camel.apache.org/releases/k-1.10.0/

#3546 Feat(trait): Knative service visibility support

Can someone please close this issue if possible?

@squakez
Copy link
Contributor

squakez commented Sep 7, 2022

Sure, thanks for reporting!

@squakez squakez closed this as completed Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants