Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable SinkBinding automatically #1654

Closed
nicolaferraro opened this issue Aug 10, 2020 · 0 comments · Fixed by #1832
Closed

Enable SinkBinding automatically #1654

nicolaferraro opened this issue Aug 10, 2020 · 0 comments · Fixed by #1832
Assignees
@nicolaferraro
Labels
area/knative Related to Knative
Milestone
1.3.0

Comments

@nicolaferraro
Copy link
Member

In the following case, we should automatically enable sink-binding:

  • When an integration has a single knative output sink
  • When the integration object is not owned by a Knative resource (in this case, it's likely that the integration is owned by a source, so we should not create a second source -- sinkbinding is a source)

Both conditions must hold.
@nicolaferraro nicolaferraro added the area/knative Related to Knative label Aug 10, 2020
@nicolaferraro nicolaferraro added this to the 1.2.0 milestone Aug 10, 2020
@lburgazzoli lburgazzoli mentioned this issue Aug 24, 2020
Closed
@nicolaferraro nicolaferraro modified the milestones: 1.2.0, 1.3.0 Sep 21, 2020
@nicolaferraro nicolaferraro self-assigned this Nov 27, 2020
nicolaferraro added a commit to nicolaferraro/camel-k that referenced this issue Nov 27, 2020
@nicolaferraro
Fix apache#1654: enable sinkbinding automatically
337582d
nicolaferraro added a commit to nicolaferraro/camel-k that referenced this issue Nov 27, 2020
@nicolaferraro
Fix apache#1654: enable sinkbinding automatically
e9b7aeb
@nicolaferraro nicolaferraro mentioned this issue Nov 27, 2020
Merged
nicolaferraro added a commit to nicolaferraro/camel-k that referenced this issue Dec 2, 2020
@nicolaferraro
Fix apache#1654: enable sinkbinding automatically
0eb3100
nicolaferraro added a commit to nicolaferraro/camel-k that referenced this issue Dec 2, 2020
@nicolaferraro
Fix apache#1654: disable sinkbinding in kameletbinding explicit uri
641974d
nicolaferraro added a commit to nicolaferraro/camel-k that referenced this issue Dec 3, 2020
@nicolaferraro
Fix apache#1654: fix failing test
3133a54
nicolaferraro added a commit that referenced this issue Dec 4, 2020
@nicolaferraro
Fix #1654: enable sinkbinding automatically
787f97e
nicolaferraro added a commit that referenced this issue Dec 4, 2020
@nicolaferraro
Fix #1654: disable sinkbinding in kameletbinding explicit uri
55ce357
@nicolaferraro nicolaferraro mentioned this issue Dec 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolaferraro nicolaferraro

Labels
area/knative Related to Knative
Projects
None yet
Milestone
1.3.0
Development

Successfully merging a pull request may close this issue.

Fix #1654: enable sinkbinding automatically nicolaferraro/camel-k
1 participant
@nicolaferraro